Add smart paste terminal feature

src/vs/workbench/contrib/terminal/browser/detachedTerminal.ts

@@ -12,7 +12,7 @@ import { MicrotaskDelay } from '../../../../base/common/symbols.js';
 import { IInstantiationService } from '../../../../platform/instantiation/common/instantiation.js';
 import { TerminalCapabilityStore } from '../../../../platform/terminal/common/capabilities/terminalCapabilityStore.js';
 import { IMergedEnvironmentVariableCollection } from '../../../../platform/terminal/common/environmentVariable.js';
-import { ITerminalBackend } from '../../../../platform/terminal/common/terminal.js';
+import { ITerminalBackend, TerminalShellType } from '../../../../platform/terminal/common/terminal.js';
 import { IDetachedTerminalInstance, IDetachedXTermOptions, IDetachedXtermTerminal, ITerminalContribution, IXtermAttachToElementOptions } from './terminal.js';
 import { TerminalExtensionsRegistry } from './terminalExtensions.js';
 import { TerminalWidgetManager } from './widgets/widgetManager.js';
@@ -72,6 +72,7 @@ export class DetachedTerminal extends Disposable implements IDetachedTerminalIns
 			}
 		});
 	}
+	shellType: TerminalShellType | undefined;
 
 	get selection(): string | undefined {
 		return this._xterm && this.hasSelection() ? this._xterm.raw.getSelection() : undefined;

src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts

@@ -133,22 +133,11 @@ Registry.as<IViewsRegistry>(ViewContainerExtensions.ViewsRegistry).registerViews
 // Register actions
 registerTerminalActions();
 
-const enum Constants {
+export const enum Constants {
 	/** The text representation of `^<letter>` is `'A'.charCodeAt(0) + 1`. */
 	CtrlLetterOffset = 64
 }
 
-// An extra Windows-only ctrl+v keybinding is used for pwsh that sends ctrl+v directly to the
-// shell, this gets handled by PSReadLine which properly handles multi-line pastes. This is
-// disabled in accessibility mode as PowerShell does not run PSReadLine when it detects a screen
-// reader. This works even when clipboard.readText is not supported.
-if (isWindows) {
-	registerSendSequenceKeybinding(String.fromCharCode('V'.charCodeAt(0) - Constants.CtrlLetterOffset), { // ctrl+v
-		when: ContextKeyExpr.and(TerminalContextKeys.focus, ContextKeyExpr.equals(TerminalContextKeyStrings.ShellType, GeneralShellType.PowerShell), CONTEXT_ACCESSIBILITY_MODE_ENABLED.negate()),
-		primary: KeyMod.CtrlCmd | KeyCode.KeyV
-	});
-}
-
 // Map certain keybindings in pwsh to unused keys which get handled by PSReadLine handlers in the
 // shell integration script. This allows keystrokes that cannot be sent via VT sequences to work.
 // See https://github.com/microsoft/terminal/issues/879#issuecomment-497775007

src/vs/workbench/contrib/terminal/browser/terminal.ts

@@ -186,6 +186,11 @@ export interface IBaseTerminalInstance {
 	 */
 	readonly selection: string | undefined;
 
+	/**
+	 * The shell type of the terminal.
+	 */
+	readonly shellType: TerminalShellType | undefined;
+
 	/**
 	 * Check if anything is selected in terminal.
 	 */

src/vs/workbench/contrib/terminal/terminalContribExports.ts

@@ -8,6 +8,7 @@ import { TerminalAccessibilityCommandId, defaultTerminalAccessibilityCommandsToS
 import { terminalAccessibilityConfiguration } from '../terminalContrib/accessibility/common/terminalAccessibilityConfiguration.js';
 import { terminalAutoRepliesConfiguration } from '../terminalContrib/autoReplies/common/terminalAutoRepliesConfiguration.js';
 import { terminalInitialHintConfiguration } from '../terminalContrib/chat/common/terminalInitialHintConfiguration.js';
+import { terminalClipboardConfiguration } from '../terminalContrib/clipboard/common/terminalClipboardConfiguration.js';
 import { terminalCommandGuideConfiguration } from '../terminalContrib/commandGuide/common/terminalCommandGuideConfiguration.js';
 import { TerminalDeveloperCommandId } from '../terminalContrib/developer/common/terminal.developer.js';
 import { defaultTerminalFindCommandToSkipShell } from '../terminalContrib/find/common/terminal.find.js';
@@ -46,6 +47,7 @@ export const terminalContribConfiguration: IConfigurationNode['properties'] = {
 	...terminalSuggestConfiguration,
 	...terminalTypeAheadConfiguration,
 	...terminalZoomConfiguration,
+	...terminalClipboardConfiguration
 };
 
 // Export commands to skip shell from terminalContrib - this is an exception to the eslint rule

src/vs/workbench/contrib/terminalContrib/clipboard/browser/smartPasteUtils.ts

@@ -0,0 +1,110 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import { OS } from '../../../../../base/common/platform.js';
+import { detectLinks } from '../../links/browser/terminalLinkParsing.js';
+import { fallbackMatchers } from '../../links/browser/terminalLocalLinkDetector.js';
+
+
+/**
+ * Manages all the terminal smart paste related operations
+ */
+export class SmartPasteUtils {
+
+	private static _detectLink(text: string): boolean {
+		const links = detectLinks(text, OS);
+
+		/* Check the first link only */
+		if (links.length > 0 && links[0]?.path?.text === text) {
+			return true;
+		}
+
+		return false;
+	}
+
+	private static _matchFallbackMatchers(text: string) {
+		let hasMatchedFallbackMatchers = false;
+
+		fallbackMatchers.forEach((regexPattern) => {
+			if (regexPattern.test(text)) {
+				hasMatchedFallbackMatchers = true;
+				return;
+			}
+		});
+		return hasMatchedFallbackMatchers;
+	}
+
+	/**
+	 * Check if the input string looks like a path
+	 * @param text input string, returns true if it looks like a path
+	 */
+	static isPathLike(text: string): boolean {
+		// Regex to detect common path formats
+
+		const windowsPathPattern = /^[a-zA-Z]:(?:\\|\/)/;  // Windows absolute path
+		const windowsUNCPathPattern = /^\\\\/;             // Windows UNC path
+		const unixPathPattern = /^\/|(?:\w+\/)/; // Unix/Linux/macOS paths
+
+		return windowsPathPattern.test(text) ||
+			windowsUNCPathPattern.test(text) ||
+			unixPathPattern.test(text) ||
+			/* Checks below are to validate if the path is relative */
+			this._detectLink(text) ||
+			this._matchFallbackMatchers(text);
+	}
+
+	/**
+	 * Wraps the input path in " and escapes the " in the path
+	 * @param path input path which needs to be wrapped in "
+	 */
+	static wrapAndEscapePath(path: string, escapeChar: string): string {
+		// Escape double quotes in the path
+		const escapedPath = path.replace(/"/g, `${escapeChar}"`);
+		// Wrap the escaped path in double quotes
+		return `"${escapedPath}"`;
+	}
+
+	/**
+	 * Handles smartPaste for paths depending on the type of the terminal
+	 * @param text the string that's going to be pasted on the terminal
+	 * @param shellType the type of terminal on which the paste operation was done
+	 */
+	static handleSmartPaste(text: string, shellType: string): string {
+		if (!this.isPathLike(text)) {
+			return text;  // Return the string as is if it's not detected as a path
+		}
+
+		switch (shellType) {
+			case 'gitbash':
+			case 'zsh':
+			case 'tmux':
+			case 'fish':
+			case 'bash':
+				{
+					// Escape backslashes and wrap in double quotes if necessary
+					const escapedPath = text.replace(/\\/g, '\\\\');
+					if (text.includes(' ')) {
+						return this.wrapAndEscapePath(escapedPath, '\\');
+					}
+					return escapedPath;
+				}
+
+			case 'pwsh':
+				if (text.includes(' ')) {
+					return this.wrapAndEscapePath(text, '`');
+				}
+				return text;
+			case 'cmd':
+				// Simply wrap in quotes if spaces are present
+				if (text.includes(' ')) {
+					return this.wrapAndEscapePath(text, '^');
+				}
+				return text;
+
+			default:
+				return text;  // If shell type is unknown, return text as is
+		}
+	}
+}

src/vs/workbench/contrib/terminalContrib/clipboard/browser/terminal.clipboard.contribution.ts

@@ -96,8 +96,17 @@ export class TerminalClipboardContribution extends Disposable implements ITermin
 			return;
 		}
 
+		let shellType = '';
+
+		shellType = this._ctx.instance.shellType ?? '';
+
 		let currentText = value;
-		const shouldPasteText = await this._instantiationService.invokeFunction(shouldPasteTerminalText, currentText, this._xterm?.raw.modes.bracketedPasteMode);
+		const shouldPasteText = await this._instantiationService.invokeFunction(
+			shouldPasteTerminalText,
+			currentText,
+			this._xterm?.raw.modes.bracketedPasteMode,
+			shellType
+		);
 		if (!shouldPasteText) {
 			return;
 		}

src/vs/workbench/contrib/terminalContrib/clipboard/browser/terminalClipboard.ts

@@ -8,15 +8,28 @@ import { IConfigurationService } from '../../../../../platform/configuration/com
 import { IDialogService } from '../../../../../platform/dialogs/common/dialogs.js';
 import { ServicesAccessor } from '../../../../../platform/instantiation/common/instantiation.js';
 import { TerminalSettingId } from '../../../../../platform/terminal/common/terminal.js';
+import { Constants } from '../../../terminal/browser/terminal.contribution.js';
+import { TerminalClipboardSettingId } from '../common/terminalClipboardConfiguration.js';
+import { SmartPasteUtils } from './smartPasteUtils.js';
 
-export async function shouldPasteTerminalText(accessor: ServicesAccessor, text: string, bracketedPasteMode: boolean | undefined): Promise<boolean | { modifiedText: string }> {
+export async function shouldPasteTerminalText(accessor: ServicesAccessor, text: string, bracketedPasteMode: boolean | undefined, shellType: string): Promise<boolean | { modifiedText: string }> {
 	const configurationService = accessor.get(IConfigurationService);
 	const dialogService = accessor.get(IDialogService);
 
 	// If the clipboard has only one line, a warning should never show
 	const textForLines = text.split(/\r?\n/);
+
+	const isSmartPasteAllowed = configurationService.getValue(TerminalClipboardSettingId.EnableSmartPaste);
+	// If the string is a path process it depending on the shell type
+	// multi line strings aren't handled
+	let modifiedText = text;
+
+	if (isSmartPasteAllowed) {
+		modifiedText = SmartPasteUtils.handleSmartPaste(text, shellType);
+	}
+
 	if (textForLines.length === 1) {
-		return true;
+		return text === modifiedText ? true : { modifiedText: modifiedText };
 	}
 
 	// Get config value
@@ -94,8 +107,14 @@ export async function shouldPasteTerminalText(accessor: ServicesAccessor, text:
 		return false;
 	}
 
-	if (result.confirmed && checkboxChecked) {
-		await configurationService.updateValue(TerminalSettingId.EnableMultiLinePasteWarning, 'never');
+	if (result.confirmed) {
+		/* Send ctrl+v to PSReadline if its a pwsh instance */
+		if (shellType === 'pwsh' && !result.singleLine) {
+			return { modifiedText: String.fromCharCode('V'.charCodeAt(0) - Constants.CtrlLetterOffset) };
+		}
+		if (checkboxChecked) {
+			await configurationService.updateValue(TerminalSettingId.EnableMultiLinePasteWarning, 'never');
+		}
 	}
 
 	if (result.singleLine) {

src/vs/workbench/contrib/terminalContrib/clipboard/common/terminalClipboardConfiguration.ts

@@ -0,0 +1,24 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import type { IStringDictionary } from '../../../../../base/common/collections.js';
+import { localize } from '../../../../../nls.js';
+import type { IConfigurationPropertySchema } from '../../../../../platform/configuration/common/configurationRegistry.js';
+
+export const enum TerminalClipboardSettingId {
+	EnableSmartPaste = 'terminal.integrated.EnableSmartPaste',
+}
+
+export interface ITerminalClipboardConfiguration {
+	enableSmartPaste: boolean;
+}
+
+export const terminalClipboardConfiguration: IStringDictionary<IConfigurationPropertySchema> = {
+	[TerminalClipboardSettingId.EnableSmartPaste]: {
+		markdownDescription: localize('terminal.integrated.enableSmartPaste', "Whether or not to allow smart paste to automatically wrap file path with double quotes"),
+		type: 'boolean',
+		default: false
+	},
+};