Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up a11y terminalContrib/ #230387

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Clean up a11y terminalContrib/ #230387

merged 1 commit into from
Oct 3, 2024
+26 −30

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 3, 2024 •
edited
Loading

  • Removes unneeded injected services
  • Removes _ from non-privates
  • Sort ctor injected services

cc @meganrogge

@Tyriar
Clean up a11y terminalContrib/
aa34846 
- Removes unneeded injected services
- Removes _ from non-privates
- Sort ctor injected services
@Tyriar Tyriar added this to the October 2024 milestone Oct 3, 2024
@Tyriar Tyriar requested a review from meganrogge October 3, 2024 11:29
@Tyriar Tyriar self-assigned this Oct 3, 2024
@Tyriar Tyriar enabled auto-merge October 3, 2024 11:29
@Tyriar Tyriar removed the request for review from meganrogge October 3, 2024 11:46
@Tyriar Tyriar mentioned this pull request Oct 3, 2024
Merged
@Tyriar Tyriar merged commit d661252 into main Oct 3, 2024
8 checks passed
@Tyriar Tyriar deleted the tyriar/a11y_contrib_cleanup branch October 3, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
October 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @bpasero