Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delay task provider activation until the task is found/run or fallback to activating all #223136

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jul 22, 2024

fix #192043

See #192043 (comment) for the repro and explanation

@meganrogge meganrogge self-assigned this Jul 22, 2024
@meganrogge meganrogge requested review from connor4312 and alexr00 July 22, 2024 21:40
@meganrogge meganrogge added this to the August 2024 milestone Jul 22, 2024
Copy link
Member

@connor4312 connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@meganrogge meganrogge merged commit c7c6d05 into main Jul 22, 2024
6 checks passed
@meganrogge meganrogge deleted the merogge/task-fix branch July 22, 2024 22:04
@meganrogge meganrogge modified the milestones: August 2024, July 2024 Jul 22, 2024
@alexr00
Copy link
Member

alexr00 commented Jul 23, 2024

👍 looks good.

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Code 1.81.1 starts *all* onTaskType extensions when debugging
3 participants