-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak ESLint #219628
Closed
Closed
Unbreak ESLint #219628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great catch. |
dbaeumer
approved these changes
Jul 3, 2024
sandy081
approved these changes
Jul 3, 2024
@arvid220u your change doesn't pass the build pipeline since you formatted the code with spaces instead of tabs. I will redo the change. |
See #220037 for the merged pull request. To get this in all reported errors needed to fixed as well. |
auto-merge was automatically disabled
July 5, 2024 10:35
Pull request was closed
El lun., 1 de julio de 2024 7:13 p. m., Arvid Lunnemark <
***@***.***> escribió:
… Since 13a88a8
<13a88a8>,
I believe that yarn eslint has been broken. It runs for 10 seconds and
reports a success.
The problem, I believe, is that gulp-eslint does not parse double
exclamation marks. This PR changes the double exclamation mark into no
exclamation mark at all, which makes eslint work again, and which I
believe also makes the original intent of the 13a88a8
<13a88a8>
commit work.
------------------------------
You can view, comment on, or merge this pull request online at:
#219628
Commit Summary
- 93d3a91
<93d3a91>
unbreak eslint
File Changes
(1 file <https://github.com/microsoft/vscode/pull/219628/files>)
- *M* build/filters.js
<https://github.com/microsoft/vscode/pull/219628/files#diff-66d916558fa2c4e6b1e08942e9ea521326e3bd47353f34649cf5de289f05a065>
(2)
Patch Links:
- https://github.com/microsoft/vscode/pull/219628.patch
- https://github.com/microsoft/vscode/pull/219628.diff
—
Reply to this email directly, view it on GitHub
<#219628>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFY2YSFHCRGICD2T6XM6DUTZKH5CNAVCNFSM6AAAAABKGRHTUOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4DIOJZGU2DCNY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 13a88a8, I believe that
yarn eslint
has been broken. It runs for 10 seconds and reports a success.The problem, I believe, is that
gulp-eslint
does not parse double exclamation marks. This PR changes the double exclamation mark into no exclamation mark at all, which makeseslint
work again, and which I believe also makes the original intent of the 13a88a8 commit work.There seems to be a few lints that have gone unnoticed because of this, but I will leave that to subsequent PRs by the respective code owners.
I might be missing something! But figured I'd send it here in case I'm not :)