Gather basic notebook info along with perf data #210712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Apr 19, 2024
| markdownLength = (codeLength || 0) + cell.getTextLength(); | ||
| } | ||
| } | ||
| notebookStatsLoaded = stopWatch.elapsed(); |
There was a problem hiding this comment.
Added this to see how much of an impact this will have,
If we find out that this is slow, we can always disable this.
Also from my testing in OSS, this takes less than 1ms.
amunger
approved these changes
Apr 19, 2024
sergioengineer
pushed a commit
to sergioengineer/VimSCode
that referenced
this pull request
Apr 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#209787