Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the possibility to enrich hovers with additional data #210472

Merged
merged 110 commits into from
Apr 19, 2024
Merged

Adding the possibility to enrich hovers with additional data #210472

merged 110 commits into from
Apr 19, 2024

Conversation

aiday-mar
Copy link
Contributor

PR which adds the possibility to enrich hovers with additional data

@aiday-mar
wip
ef39b20
@aiday-mar
adding the boolean extended
0a4bef1
@aiday-mar
on shift, we show the extended hover
be8a5c1
@aiday-mar
creating instead an api proposal
3d6459f
@aiday-mar
adding code in order to propagate the extended keyword
8727fa8
@aiday-mar
adding code in order to use insead an additional action, show extende…
818a6d0 
…d hover
@aiday-mar
making changes so one can transition to more extended information
3e6b577
@aiday-mar
making hover correctly appear
423994c
@aiday-mar
adding a setting and showing instead the extended hover information.
5c7b3d8
@aiday-mar
making chanegs
357e8bf
@aiday-mar
polishing the code
e85df6c
@aiday-mar
extending the hover
ab57fa9
@aiday-mar
adding the actions into a toolbar in the markdown hover when it can b…
d342e4b 
…e extended
@aiday-mar
adding code in order to align the actions
f90f526
@aiday-mar
changing the code so as to directly have the code inside of the markd…
c2e2a5e 
…own participant
@aiday-mar
refactoring the code
0f2f5cb
@aiday-mar
polishing the code
e6c0a45
@aiday-mar
polishing the code
5addb57
@aiday-mar
adding the disposable store into the markdown hover participant
b263f15
@aiday-mar
letting the disposable store be undefined
4c56bcb
@aiday-mar
adding the on contents changes into the extend or constract focused m…
a80074a 
…essage call
@aiday-mar
polish
5b337a6
@aiday-mar
changing the UI to chevron up and chevron down
6ed3d9f
@aiday-mar
setting different opacity level
c2accf2
@aiday-mar
removing the refactoring
24bee31
@aiday-mar
fixing compile errors
3f40d33
@aiday-mar
Merge branch 'main' into aiday/hoverExtension
4ac442e
@aiday-mar
changing the api
9830188
@aiday-mar
polishing the code
a288dad
@aiday-mar
adding proposed api provideHover
ec45651
@aiday-mar aiday-mar self-assigned this Apr 16, 2024
@aiday-mar aiday-mar requested a review from hediet April 19, 2024 14:38
@aiday-mar aiday-mar marked this pull request as ready for review April 19, 2024 14:38
@aiday-mar aiday-mar enabled auto-merge (squash) April 19, 2024 14:39
@VSCodeTriageBot VSCodeTriageBot added this to the April 2024 milestone Apr 19, 2024
@aiday-mar aiday-mar merged commit b8eba5d into main Apr 19, 2024
6 checks passed
@aiday-mar aiday-mar deleted the aiday/hoverExtension2 branch April 19, 2024 17:17
This was referenced Apr 22, 2024
Closed
Closed
sergioengineer pushed a commit to sergioengineer/VimSCode that referenced this pull request Apr 23, 2024
@aiday-mar @sergioengineer
Adding the possibility to enrich hovers with additional data (microso…
8994656 
…ft#210472)

Adding the possibility to enrich hovers with additional data
@aiday-mar aiday-mar mentioned this pull request Apr 25, 2024
Open
@microsoft microsoft locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hediet hediet hediet approved these changes

Assignees

@aiday-mar aiday-mar

Labels
None yet
Projects
None yet
Milestone
April 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@aiday-mar @hediet @VSCodeTriageBot