Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trim end of matched link #209469

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: trim end of matched link #209469

merged 1 commit into from
Apr 3, 2024

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Apr 3, 2024

I still sometimes see additional encoded spaces ('%20' strings) at the end of the
PR quick fix links, and noticed that the regex matches every character. Instead of modifying the regex, I added a trimEnd call.

@rzhao271 rzhao271 requested a review from meganrogge April 3, 2024 17:57
@rzhao271 rzhao271 self-assigned this Apr 3, 2024
@rzhao271 rzhao271 added this to the April 2024 milestone Apr 3, 2024
@rzhao271 rzhao271 enabled auto-merge (squash) April 3, 2024 17:57
meganrogge
meganrogge approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rzhao271 rzhao271 merged commit fb7f833 into main Apr 3, 2024
7 checks passed
@rzhao271 rzhao271 deleted the rzhao271/trim-match branch April 3, 2024 18:25
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
April 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@rzhao271 @meganrogge