-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] extension update command #199893
[CLI] extension update command #199893
Conversation
src/vs/platform/extensionManagement/common/extensionManagementCLI.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/extensionManagement/common/extensionManagementCLI.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/extensionManagement/common/extensionManagementCLI.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/extensionManagement/common/extensionManagementCLI.ts
Outdated
Show resolved
Hide resolved
@connor4312 Can you please check the changes in rust CLI part? |
Co-authored-by: Sandeep Somavarapu <[email protected]>
Rust changes look ok 👍 |
@sandy081 Thank you for the review, I made the consequent changes I had one problem of name collision: Because this is not the goal of this PR to resolve the issue, I choosed the simplest solution and renamed the one in |
This is ok for me. Let me know once you have incorporated all changes. |
I already incorporated all changes you requested, so if renaming as |
src/vs/platform/extensionManagement/common/extensionManagementCLI.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/extensionManagement/common/extensionManagementCLI.ts
Outdated
Show resolved
Hide resolved
LGTM, can you please resolve the merge conflicts? |
Verified with latest build of code-insiders: the update seems working, but prints a DepreciationWarning (probably inside the
Tested on Ubuntu 20.04 , code-insiders installed with snap. |
This is being tracked separately. Tagging this as verified based on above comment |
Does this update all extensions? or only all the extensions for the specified profile ( |
Profile should be passed to update for a specific profile, otherwise extensions from default profile are updated. |
This PR adds a cli command to update all extensions
code --list-extensions
, which works without opening VSCode as GUI.This fixes the issue #56578 .
For reference, this is the following of the ticket re-opening after the discussion in this issue #196155 (comment) .
This have been linted using yarn and tested with the provided test.sh script.
I also tested that with classic extensions, but due to difficulties to test, I have not tested any prerelease upgrades, and not tested with vscode server. For prerelease, as soon as I will have some outdated one in my test setup I will be able to update this comment accordingly.
I am also not a TypeScript developer so if I wrote someting not optimal in the language, don't hesitate to state it below.