Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update license for OSS Tool #188988

Merged
merged 2 commits into from
Jul 27, 2023
Merged

update license for OSS Tool #188988

merged 2 commits into from
Jul 27, 2023

Conversation

andreamah
Copy link
Contributor

No description provided.

@andreamah andreamah self-assigned this Jul 26, 2023
@andreamah andreamah marked this pull request as ready for review July 26, 2023 23:49
@andreamah andreamah changed the title try to update licenses update license for OSS Tool Jul 26, 2023
@vscodenpa vscodenpa added this to the July 2023 milestone Jul 26, 2023
{
"name": "cacheable-request",
"prependLicenseText": [
"Copyright (c) cacheable-request authors"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because there is no copyright statement in https://github.com/jaredwray/cacheable/blob/main/LICENSE. It is like

"Copyright (c) tunnel-agent authors"

@rzhao271
Copy link
Contributor

Also adding Connor to review the CLI changes

@rzhao271 rzhao271 requested a review from connor4312 July 27, 2023 00:13
@connor4312
Copy link
Member

CLI license lgtm (addition of the new file is intentional)

@andreamah andreamah requested a review from rzhao271 July 27, 2023 14:28
@andreamah andreamah merged commit b448b21 into main Jul 27, 2023
@andreamah andreamah deleted the premier-asp branch July 27, 2023 15:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants