Adopt utility process for pty host on Electron #182345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
commented
May 15, 2023
src/vs/platform/terminal/electron-main/electronPtyHostStarter.ts
Outdated
Show resolved
Hide resolved
|
@bpasero ready for review 🙂 |
bpasero
previously approved these changes
May 15, 2023
There was a problem hiding this comment.
Performance related question: when is the PTY host starting, will a window trigger the request when a terminal is opened or do we eagerly spawn the PTY host?
I suggest we get this going in insiders to try it out, I did not do a deep review of the pieces but trust your expertise in this area.
One thing I saw when testing: a message [main 2023-05-15T15:58:20.775Z] ptyHost terminated unexpectedly with code 0 shows when I open a terminal, reload the window and then quit.
Tyriar
force-pushed
the
tyriar/utility_ptyhost__2
branch
from
25f6ada to
a12c412
Compare
The clean up is handled by Electron
roblourens
approved these changes
May 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #175335