Support VSCODE_ENV_* variables to adjust environment in shell integration scripts #179472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
approved these changes
Apr 7, 2023
| // export enum EnvironmentVariableMutatorTiming { | ||
| // AtSpawn = 1, | ||
| // AfterShellIntegration = 2 | ||
| // // TODO: Do we need a both? |
There was a problem hiding this comment.
We likely need both as shell integration is not guaranteed to activate.
karrtikr
reviewed
Apr 7, 2023
| VALUE="$(echo $ITEM | cut -d "=" -f 2)" | ||
| export $VARNAME="$VALUE${!VARNAME}" | ||
| done | ||
| builtin unset VSCODE_ENV_REPLACE |
There was a problem hiding this comment.
Should be VSCODE_ENV_PREPEND instead
| VALUE="$(echo $ITEM | cut -d "=" -f 2)" | ||
| export $VARNAME="${!VARNAME}$VALUE" | ||
| done | ||
| builtin unset VSCODE_ENV_REPLACE |
There was a problem hiding this comment.
Should be VSCODE_ENV_APPEND instead
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #179476
This implements the shell script part of #179476. With this, an extension can temporarily set the following variables via the
EnvironmentVariableCollectionto get this behavior, all of which have the formatvar1=value1:var2=value2VSCODE_ENV_REPLACE: Replace the variableVSCODE_ENV_PREPEND: Add the value to the start of the variableVSCODE_ENV_APPEND: Add the value to the end of the variableI'll be out for a few weeks so this is an MVP for the Python extension to use it. Eventually, when the API is added, we'll prevent it from working like this be sanitizing out any
VSCODE_ENV_*variables when applying the environment variable collection to the process as we want VS Code core to have full control over them.