Initial cut of seeded command palette #171293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
commented
Jan 13, 2023
src/vs/workbench/contrib/quickaccess/browser/commandsQuickAccess.ts
Outdated
Show resolved
Hide resolved
mjbvz
approved these changes
Jan 17, 2023
bpasero
reviewed
Jan 18, 2023
| @@ -333,6 +333,11 @@ const registry = Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Con | |||
| 'description': localize('preserveInput', "Controls whether the last typed input to the command palette should be restored when opening it the next time."), | |||
| 'default': false | |||
| }, | |||
| 'workbench.commandPalette.experimental.suggestCommands': { | |||
| 'type': 'boolean', | |||
| 'description': localize('suggestCommands', "Controls whether the command palette should have a list of commonly used commands."), | |||
There was a problem hiding this comment.
@TylerLeonhardt should this be marked as an experimental setting to run an experiment and measure the impact?
There was a problem hiding this comment.
had a follow up PR doing exactly that.
bpasero
reviewed
Jan 18, 2023
| ) { | ||
| const suggestCommands = configurationService.getValue<boolean>('workbench.commandPalette.experimental.suggestCommands'); |
There was a problem hiding this comment.
@TylerLeonhardt I feel there is now a bit of an ugly repetition of the same code to handle the suggested commands option based on config. What I typically do in these cases is to extract the config handler into a method and then call it twice: once initially and once from the event. The event itself then becomes optional, see for example:
vscode/src/vs/workbench/browser/workbench.ts
Line 264 in d8568bb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169091