Fix uri transformer slowness over large buffers #171126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #138784
tl;dr of that issue
Turns out that most of the CPU time is in
_transformIncomingURIs
because it is iterating the large output VSBuffer. There will never be a URI in there, so this changes skips them.As a separate optimization, we could also avoid transferring the full notebook model to save, since the EH should already have this model which has been updated incrementally