Refactor "Modified in: User" indicator #166645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref #159088 The "Modified in: User" indicator is not like other indicators, because it doesn't put up a hover, and it has a link in the label itself. This PR refactors that indicator and clarifies that tab focus goes straight to the link when using keyboard navigation.
rzhao271
force-pushed
the
swift-whitefish
branch
from
d6c13e3 to
2064a84
Compare
rzhao271
changed the title
joyceerhl
approved these changes
Nov 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #159088
The "Modified in: User" indicator is not like other indicators,
because it doesn't put up a hover, and it has a link in the label itself.
This PR refactors that indicator and clarifies that tab focus goes straight to the link when using keyboard navigation.