auto profiling telemetry tweak #164259
Merged
auto profiling telemetry tweak #164259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuse the same code to send the telemetry data for the renderer and the extension host send telemetry event without annotated stacktraces send fake error event with annotated stacktraces
jrieken
commented
Oct 21, 2022
lramos15
approved these changes
Oct 21, 2022
lramos15
requested changes
Oct 21, 2022
…log and send callers twice (annotated and not)
…n host profile analysis by that
lramos15
reviewed
Oct 21, 2022
| logService.error(fakeError); | ||
|
|
||
| // send telemetry event | ||
| telemetryService.publicLog2<TelemetrySampleData, TelemetrySampleDataClassification>(`unresponsive.sample`, { |
There was a problem hiding this comment.
No need for templated string here
lramos15
approved these changes
Oct 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reuse the same code to send the telemetry data for
the renderer and the extension host
send telemetry event without annotated stacktraces
send fake error event with annotated stacktraces
This is for #163819