move builtin terminal quick fixes to contribution model #164099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Oct 20, 2022
Tyriar
reviewed
Oct 20, 2022
Yes I had forgotten, but that seems better |
meganrogge
commented
Oct 20, 2022
Tyriar
reviewed
Oct 20, 2022
This reverts commit 0d97708.
meganrogge
commented
Oct 20, 2022
meganrogge
commented
Oct 20, 2022
meganrogge
changed the title
Tyriar
reviewed
Oct 24, 2022
There was a problem hiding this comment.
I think we need to bring this to the API sync at least once before shipping it/announcing it in release notes. It could radically changes after discussing it and we don't want to waste people's time. How about we disable the extension contribution part and move the built-in ones over to the capture group system so we can essentially test the implementation of it this iteration?
src/vs/workbench/contrib/terminal/common/terminalExtensionPoints.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalQuickFixBuiltinActions.ts
Outdated
Show resolved
Hide resolved
meganrogge
changed the title
rebornix
previously approved these changes
Oct 24, 2022
andreamah
approved these changes
Oct 24, 2022
| const actions: TerminalQuickFixAction[] = []; | ||
| let fixedCommand = commandToRun; | ||
| for (const [key, value] of Object.entries(groups)) { | ||
| const varToResolve = '${group:' + `${key}` + '}'; |
There was a problem hiding this comment.
nit: can probably do '${group:' + key + '}' since key is already a string?
andreamah
reviewed
Oct 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #162950
fixes #163965