Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ActionWidgetService #164096

Merged
merged 115 commits into from
Nov 15, 2022
Merged

add ActionWidgetService #164096

merged 115 commits into from
Nov 15, 2022

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Oct 20, 2022 •
edited
Loading

fixes #162210
fixes #162067
fixes #164757

@meganrogge meganrogge requested a review from mjbvz October 20, 2022 01:55
@meganrogge meganrogge marked this pull request as draft October 20, 2022 01:55
@meganrogge meganrogge self-assigned this Oct 20, 2022
@meganrogge meganrogge requested a review from Tyriar October 20, 2022 01:56
@meganrogge
Copy link
Contributor Author

closing as have new approach

@meganrogge meganrogge closed this Oct 24, 2022
@meganrogge meganrogge reopened this Oct 25, 2022
@meganrogge meganrogge removed the request for review from mjbvz October 26, 2022 14:51
@meganrogge meganrogge requested a review from mjbvz November 10, 2022 21:52
mjbvz
mjbvz reviewed Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better! Left a few comments on things I noticed on my first look through the updated code. Let me know if you have any questions about these

src/vs/workbench/contrib/terminal/browser/widgets/terminalQuickFixList.ts Outdated Show resolved Hide resolved
src/vs/platform/actionWidget/browser/actionWidget.ts Outdated Show resolved Hide resolved
src/vs/platform/actionWidget/browser/actionWidget.ts Show resolved Hide resolved
src/vs/platform/actionWidget/browser/actionWidget.ts Outdated Show resolved Hide resolved
src/vs/platform/actionWidget/browser/actionWidget.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/widgets/terminalQuickFixList.ts Outdated Show resolved Hide resolved
@meganrogge meganrogge requested a review from mjbvz November 10, 2022 22:59
@meganrogge meganrogge requested review from mjbvz and Tyriar November 11, 2022 08:01
@meganrogge meganrogge enabled auto-merge (squash) November 15, 2022 04:33
@meganrogge meganrogge merged commit f614d0b into main Nov 15, 2022
@meganrogge meganrogge deleted the merogge/widget-comb branch November 15, 2022 04:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mjbvz mjbvz mjbvz approved these changes

@Tyriar Tyriar Awaiting requested review from Tyriar

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
November 2022
3 participants
@meganrogge @mjbvz @Tyriar