Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch workspace restricted settings to use indicators #163601

Merged
merged 8 commits into from
Oct 14, 2022
Merged

Switch workspace restricted settings to use indicators #163601

merged 8 commits into from
Oct 14, 2022

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Oct 13, 2022 •
edited by sandy081
Loading

Ref #157564

Current issues:

  • When changing a workspace restricted setting in the Settings editor, the value is written once to the JSON file, but then the value isn't refreshed properly

@rzhao271 rzhao271 requested a review from sandy081 October 13, 2022 23:19
@rzhao271 rzhao271 self-assigned this Oct 13, 2022
@rzhao271 rzhao271 added this to the October 2022 milestone Oct 13, 2022
@sandy081
Copy link
Member

Fixed the bug mentioned in the issue and also updated the PR with some changes (feedback). But IMO the following visual representation is too subtle to say that the value is not getting applied.

image

@rzhao271 rzhao271 marked this pull request as ready for review October 14, 2022 18:09
@rzhao271
Copy link
Contributor Author

LGTM, thanks again for the configuration changes!
My current plan is to squash and merge in the change and get a few rounds of feedback.
If anything big comes up, I can revert the squash commit.

@rzhao271 rzhao271 merged commit 740d837 into main Oct 14, 2022
@rzhao271 rzhao271 deleted the rzhao271/policy-indicator branch October 14, 2022 18:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandy081 sandy081 sandy081 approved these changes

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
October 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@rzhao271 @sandy081