Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on typescript protocol.d.ts #163365

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Oct 11, 2022

For TS 5.0, we're making some major build changes and package cleanups stemming from our conversion from namespaces to modules. protocol.d.ts is one file I'm trying to eliminate, as it's tricky to produce in the new build. See also:

Rather than using this a d.ts file, we can depend on the same namespace as exported by tsserverlibrary instead, a file that is definitely not going away.

This actually reveals a couple of interesting things:

  • The ambient protocol namespace was being used in a couple places where it shouldn't have been.
  • Two types needed to be reexported via the protocol, implying that our protocol is not self-contained. That's something to address on the TS side, but nothing new.

@jakebailey jakebailey marked this pull request as ready for review October 12, 2022 18:09
@mjbvz mjbvz merged commit 07b8740 into microsoft:main Oct 12, 2022
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 12, 2022

Thank you!

@mjbvz mjbvz added this to the October 2022 milestone Oct 12, 2022
@jakebailey jakebailey deleted the remove-protocol-dts branch October 12, 2022 23:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants