Adopt argsCanBeInterpretedByShell from DAP #155663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weinand
reviewed
Jul 20, 2022
| if (args.length > 0) { | ||
| const cmd = quote(args.shift()!); | ||
| const arg = args.shift()!; | ||
| const cmd = argsCanBeInterpretedByShell ? arg : quote(arg); |
Contributor
There was a problem hiding this comment.
You might want to consider to duplicate the argument processing into two branches of an if-statement controlled by the argsCanBeInterpretedByShell flag. Keeping the two cases apart makes them easier to understand than having one piece of code sprinkled with the argsCanBeInterpretedByShell flag (especially if we'll have to add more logic for future fixes...)
weinand
reviewed
Jul 20, 2022
| } | ||
| for (const a of args) { | ||
| command += (a === '<' || a === '>') ? a : quote(a); | ||
| command += (a === '<' || a === '>' || argsCanBeInterpretedByShell) ? a : quote(a); |
Contributor
There was a problem hiding this comment.
here the logic is too simple - no need to separate the logic...
weinand
approved these changes
Jul 20, 2022
Contributor
weinand
left a comment
weinand
left a comment
There was a problem hiding this comment.
Currently the argsCanBeInterpretedByShell flag is not used for external terminals. We should create a (debt?) issue for investigating this...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #149910