-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support find widget in lists/trees #152481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
force-pushed
the
joao/northern-wildebeest
branch
from
June 22, 2022 18:42
e5454f0
to
0cb05e8
Compare
joaomoreno
force-pushed
the
joao/northern-wildebeest
branch
from
July 15, 2022 14:58
ee746bc
to
4a78acb
Compare
navigation and tree find. use proper FindInput widget
joaomoreno
force-pushed
the
joao/northern-wildebeest
branch
from
July 16, 2022 11:33
4a78acb
to
01b57e3
Compare
joaomoreno
changed the title
Explore improving the discoverability of filtering in tree views
Support find widget in lists/trees
Jul 16, 2022
rebornix
reviewed
Jul 18, 2022
jrieken
reviewed
Jul 18, 2022
jrieken
previously approved these changes
Jul 18, 2022
@joaomoreno there is CI failures |
jrieken
approved these changes
Jul 18, 2022
jrieken
pushed a commit
that referenced
this pull request
Jul 18, 2022
* replace list type filter and tree type label controller with list type navigation and tree find. use proper FindInput widget * make sure vim doesn't break * polish outline use case * 💄 * remove unused import
Is there a way to make it search through closed folders too? |
@FoundationKen not yet. See #66971 |
This was referenced Aug 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This PR replaces the existing list/tree type filter:
with an bona fide find widget:
While a seemingly simple change, this has some (desired) consequences when searching/filtering in trees. Namely:
A
will focus the next element which starts withA
./
command will trigger simple keyboard navigation, as opposed to opening the find widget. The VIM extension has the option to change this behavior themselves. cc @J-FieldsChanges
We've taken the opportunity to reframe and rephrase the feature along with all its settings/commands/context keys. Notice that all old names will be marked as deprecated but still be respected for a while, until enough time has passed for extensions to migrate to the new ones.
In general:
Settings
workbench.list.keyboardNavigation
has been renamed toworkbench.list.defaultFindMode
workbench.list.automaticKeyboardNavigation
has been deletedCommands
list.toggleKeyboardNavigation
has been renamed tolist.triggerTypeNavigation
list.find
has been addedlist.closeFind
has been addedlist.toggleFilterOnType
has been renamed tolist.toggleFindMode
Context Keys
Mainly used by the vim extension:
listSupportsKeyboardNavigation
has been renamed tolistSupportsTypeNavigation
listAutomaticKeyboardNavigation
has been renamed tolistTypeNavigationMode
Pending Items
Fixes #70646
Fixes #146806
Fixes #153612
cc @misolori