Provide an option to hide the activity bar #14940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where activity bar would be visible on startup even if it was set to be hidden Fix bug where settings would not reflect activity bar visibility
|
Good,thank you. This is what I am expecting. |
|
@golf1052 thanks! I pushed some cosmetic changes on top. I noticed that the activity bar was not following the status bar model of hiding in all aspects but rather worked like the sidebar and panel. While your change there was working I adopted the status bar model because imho the status bar and activity bar (when hidden) are not so likely to come back, whereas side bar and panel are more often being toggled. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1105
Adds the setting
workbench.activityBar.visiblethat allows the user to toggle the activity bar visibility.Adds the action
workbench.action.toggleActivityBarVisibilitythat allows the user to toggle the activity bar visibility with a keybinding or an extension to toggle the visibility through a command.