Gets rid of registerDecorationType in inlay hints controller #136517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
approved these changes
Nov 5, 2021
| @@ -209,13 +208,14 @@ export class InlayHintsController implements IEditorContribution { | |||
| return result; | |||
| } | |||
|
|
|||
| private readonly ruleFactory = new DynamicCssRules(this._editor); | |||
There was a problem hiding this comment.
nit - _ prefix for privates, also move atop ctor
| .replace(/([A-Z])/g, ([letter]) => `-${letter.toLowerCase()}`); | ||
| } | ||
|
|
||
| function themeColorToCssVar(themeColor: ThemeColor): string { |
| * Reference counting and delayed garbage collection ensure that no rules leak. | ||
| */ | ||
| export class DynamicCssRules { | ||
| private counter = 0; |
Yes. Ideally, everything related to "decoration types" is going away, as its implementation is very complicated. |
hediet
force-pushed
the
hediet/inlay-hints-controller-no-decoration-type
branch
from
051dbe7
to
39c7f7b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #132537.
The utility introduced by this PR can be made a general utility later.