Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-language-features] Add includeCompletionsWithClassMemberSnippets preference #136045

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

gabritto
Copy link
Member

This PR fixes microsoft/TypeScript#45670
TS protocol update: microsoft/TypeScript#46370

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we talked about enabling this by default, but just want to validate my memory on that @mjbvz @DanielRosenwasser

@mjbvz mjbvz merged commit d2aa181 into microsoft:main Oct 28, 2021
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 28, 2021

Thanks!

@mjbvz mjbvz added this to the October 2021 milestone Oct 28, 2021
@@ -1110,6 +1110,12 @@
"default": "allOpenProjects",
"markdownDescription": "%typescript.workspaceSymbols.scope%",
"scope": "window"
},
"typescript.suggest.includeCompletionsWithClassMemberSnippets": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually one quick note, I am going to split this into two settings: one for JS and one for TS

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add one for JavaScript because we are not supporting this completion feature in JS yet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right! I forgot about that.

Copy link

@NemoStein NemoStein Nov 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are not supporting this completion feature in JS yet

But it'll come to JS sometime in the future, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think supporting JS would be nice. I created an issue to track that, feel free to upvote it: microsoft/TypeScript#46738

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method override completions
4 participants