Use insane with notebook markdown content #131134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runs insane against markdown content. Also requires hooking up a way for renderers to detect if the workspace is trusted or not
connor4312
reviewed
Aug 18, 2021
| @@ -353,6 +353,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "highlight.js": "^10.4.1", | |||
| "insane": "^2.6.2", | |||
There was a problem hiding this comment.
In this past I've used dompurify which seems better maintained, more widely used, and has a bug bounty program. It seems like there may be a vulnerability with insane.
connor4312
approved these changes
Aug 18, 2021
rzhao271
added
candidate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs insane against markdown content. Also requires back porting up a way for renderers to detect if the workspace is trusted or not