Implements run to line.

[hediet]

This PR fixes #123872

I'm unsure if I got column 0/undefined right.

What do you think of putting "Run to line" to the top of that menu? 😉

[isidorn]

Did a first quick review and it looks good.

1. Seems like you have unused imports in debugEditorActions. Can you please fix that
2. "Run to Line" should be at the bottom of the menu so we do not break users muscle memory. Probably a lot of users memorised that adding Conditional Breakpoints is the second option, and putting a new command on the top would shift everything

I will do one more detailed review soon.

[isidorn]

Can you please implement the newly introduced method in the mockDebugService in src/vs/workbench/contrib/debug/test/browser/mockDebug.ts

[hediet]

I really should check the logs before pushing :D

[isidorn]

Yeah that can be helpful :D

[isidorn]

Run to line should only be there while debugging is active

Apart from this all seems good. Once you tackle this I will merge. Thanks a lot 👏

[hediet]

I agree. Wouldn't it be nice though if "Run to line" starts debugging if debugging is not active?

[isidorn]

Yeah I also thought about that. The problem is that starting debugging we can not guarantee that the current file will actually get run.
Though I like the idea in general and we can go down that approach to try it out.

[hediet]

Yeah I also thought about that. The problem is that starting debugging we can not guarantee that the current file will actually get run.
Though I like the idea in general and we can go down that approach to try it out.

I see. I'm okay with hiding it for now!

[isidorn]

Cool, then let's merge it in. Thanks a lot for this great PR 👏

[scybert]

@isidorn I'm curious why you are merging a failing PR.

[isidorn]

@scybert because I double checked that it is good and that it works as expected. It might have been failing in the past, before latest commits were added.

[hediet]

Also, your tests are flakey...