Whitelist comments in all JSON files #129206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 23, 2021 02:08
Currently many files contain comments but are being matched as JSON incorrectly. To fix this, let's associate `*.json` with JSONC and fix the false positive error highlights.
|
@sndst00m which tools make use of the |
|
Yes, GitHub will register all .json files as JSON with Comments. |
|
I am cleaning my forks and my pulls list, is there any blocker to this one? |
|
Let's give it a try... |
ghost
deleted the
|
I discovered that this glob only affects top-level files. |
aeschli
added a commit
that referenced
this pull request
Sep 20, 2021
|
Made the change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes false positives for error highlights in files, for example:
https://github.com/microsoft/vscode/blob/2fb5525/extensions/theme-defaults/themes/dark_plus.json#L13
Currently many files contain comments but are being matched as JSON incorrectly.
To fix this, we associate
*.jsonwith JSONC and fix the false positive error highlights.