Skip to content

typescript-language-features: Pass 'data' to completion details request #117092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjbvz merged 1 commit into from
Mar 2, 2021
Merged

typescript-language-features: Pass 'data' to completion details request #117092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion extensions/typescript-language-features/src/languageFeatures/completions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,13 @@ class MyCompletionItem extends vscode.CompletionItem {
const args: Proto.CompletionDetailsRequestArgs = {
...typeConverters.Position.toFileLocationRequestArgs(filepath, this.position),
entryNames: [
this.tsEntry.source ? { name: this.tsEntry.name, source: this.tsEntry.source } : this.tsEntry.name
// @ts-expect-error until TypeScript 4.3 protocol update
this.tsEntry.source || this.tsEntry.data ? {
name: this.tsEntry.name,
source: this.tsEntry.source,
// @ts-expect-error until TypeScript 4.3 protocol update
data: this.tsEntry.data,
} : this.tsEntry.name
]
};
const response = await client.interruptGetErr(() => client.execute('completionEntryDetails', args, requestToken.token));
Expand Down