-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Shift Shift, Ctrl Ctrl, Alt Alt Keybinds (Double press modifer keybind support) #115190
Merged
alexdima
merged 20 commits into
microsoft:master
from
PathToLife:pathtolife/double-press-keybind
Feb 2, 2021
Merged
Feature: Shift Shift, Ctrl Ctrl, Alt Alt Keybinds (Double press modifer keybind support) #115190
alexdima
merged 20 commits into
microsoft:master
from
PathToLife:pathtolife/double-press-keybind
Feb 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5ed3c97.
windows initial implementation
…to be commited later
…ier keys being ignored in getDisptachParts() all unit tests passed in this commit - modifed resolvedKeybindItem.ts to resolve modifier keybinding when loading keybind config
[build/lib/layersChecker.ts]: Reference to 'NodeJS' from '@types/node' violates layer '**/vs/**/common/**' (/home/runner/work/vscode/vscode/src/vs/platform/keybinding/common/abstractKeybindingService.ts (39,53) [build/lib/layersChecker.ts]: Reference to 'Timeout' from '@types/node' violates layer '**/vs/**/common/**' (/home/runner/work/vscode/vscode/src/vs/platform/keybinding/common/abstractKeybindingService.ts (39,60)
This was referenced Jan 27, 2021
- fix comment inconsistency - rename function camelCase
Thank you! |
Wow! Finally! Thanks guys! |
This is life changing! VSCode will be 10x better now ❤🥳 Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5280 How to detect shift shift key in VSCode?
Proposed changes:
Implemented support for quick double presses of a modifier key without unit test regressions or noticeable performance hits, while following existing architecture as closely as possible.
This implementation improves UX experience for users migrating from JetBrains platform
Keybindings.json
getDispatchString()
had logic in places inconsistent with windowsKeyboardMapper, fixedHow to test:
Performance Test:
I'm finding my self pressing "Shift Shift" in VSCode release when cross referencing code for this PR 😂😂😂🤦♂️