Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typeahead regex for move #113850

Merged
merged 1 commit into from
Jan 5, 2021
Merged

fix typeahead regex for move #113850

merged 1 commit into from
Jan 5, 2021

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Jan 5, 2021 •
edited
Loading

On macOS, we receive \x1bOC not \x1b[OC... this means that typeahead isn't "on" for arrow keys right now. This turns it "on".

fixes #113853

connor4312
connor4312 approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@connor4312 connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird

@TylerLeonhardt
Copy link
Member Author

Slight clarification... this does appear to be PowerShell specific. Even when I ran zsh from within PowerShell, the problem repro'd which is why I thought it was generic to macOS... but after setting zsh as my default shell, I see that we get \x1b[C from it which satisfies the regex.

So tl;dr: why do you do this PowerShell?

@TylerLeonhardt
Copy link
Member Author

OC/OD are valid, they are just used when a different mode is enabled: https://github.com/xtermjs/xterm.js/blob/72dbd43be61d97e9260e620f1915fe64dfb9339b/src/common/input/Keyboard.ts#L55-L82

Thanks @Tyriar!

@TylerLeonhardt TylerLeonhardt merged commit 6f56b47 into microsoft:master Jan 5, 2021
@TylerLeonhardt TylerLeonhardt deleted the fix-typeahead-regex-for-move branch January 5, 2021 22:29
@Tyriar Tyriar assigned TylerLeonhardt and unassigned joaomoreno Jan 6, 2021
@Tyriar Tyriar added this to the January 2021 milestone Jan 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@connor4312 connor4312 Awaiting requested review from connor4312

@Tyriar Tyriar Awaiting requested review from Tyriar

Assignees

@TylerLeonhardt TylerLeonhardt

Labels
None yet
Projects
None yet
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.

Type Ahead isn't "on" for cursor movement when using PowerShell on non-Windows
4 participants
@TylerLeonhardt @connor4312 @joaomoreno @Tyriar