Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smoke.test.ts #113403

Closed
wants to merge 5 commits into from
Closed

Update smoke.test.ts #113403

wants to merge 5 commits into from

Conversation

infinnie
Copy link
Contributor

@infinnie infinnie commented Dec 25, 2020

This PR reproduces the error thrown in #112537 (cf #112713). It is intended to fail, with the error thrown Should never happen.

@infinnie
Copy link
Contributor Author

This PR is intended to be the control group of #113364, where only the corresponding test exists that should fail in integration tests.

@infinnie
Copy link
Contributor Author

Don’t know why, but the Should never happen error is only sometimes thrown when it should fail.

HaoboGu added a commit to HaoboGu/vscode that referenced this pull request Jan 5, 2021
@joaomoreno
Copy link
Member

This came in via #113364

@joaomoreno joaomoreno closed this Jan 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants