Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add outline and breadcrumbs for notebooks #113303

Merged
merged 71 commits into from
Jan 4, 2021
Merged

Add outline and breadcrumbs for notebooks #113303

merged 71 commits into from
Jan 4, 2021

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Dec 22, 2020 •
edited
Loading

re #98173, this PR adds

  • an IOutlineService which allows to have outline tree, breadcrumbs, and quick pick for any editor pane
  • implements outline for document symbols (migrating the existing code)
  • implements outline for notebook cells
  • adjusts the UX elements (outline pane, breadcrumbs control) to use the new service

jrieken added 30 commits December 18, 2020 13:52
@jrieken
first version of outline service, outline creators, and implementatio…
7971d62 
…ns for document symbols and notebooks
@jrieken
wire up outline service with breadcrumbs control, WIP
e064043
@jrieken
tricky selection listening
94fbbb3
@jrieken
styles for notebook outline elements
29f556a
@jrieken
update nb breadcrumbs as you type
baadb59
@jrieken
better revealing and previewing
c51830e
@jrieken
reveal vs expand folder vs select folder...
ebb6923
@jrieken
show a root element where there is outline-breadcrumbs but none are c…
513055e 
…urrently selected
@jrieken
delete old tocProvider
4d47c40
@jrieken
remove ITableOfContentsProvider, remove duplicated code, add quick pi…
88c271c 
…cks to IOutline
@jrieken
use identity provider, some cleanup
cece1a4
@jrieken
add outline target and adjust sorting, filtering for document symbols…
822a45f 
… outline accordingly
@jrieken
simplify model, add keyboard nav support for notebooks
358f390
@jrieken
remove onDidChangeActive-event
68da4f1
@jrieken
render highlights in breadcrumbs picker
19cf2d4
@jrieken
re-use css classes for better icon support
5ebbd9a
@jrieken
use file icon (if applicable) for cells, otherwise use default icons
7593c56
@jrieken
also show cell-file icons in quick pick
609d547
@jrieken
fix compilo
ca08df3
@jrieken
move outline view state into its own file
17573d2
@jrieken
move document symbols breadcrumbs logic into its own data source
297567b
@jrieken
move delay "after big change" heuristic to new outline model
1922771
@jrieken
add config per UX (breadcrumb, tree, quick pick)
d2ee88b
@jrieken
use outline service in outline pane
9699993
@jrieken
fix compilo
22c5527
@jrieken
Merge branch 'master' into joh/toc
310a9ff
@jrieken
make sure outline is all expanded
661c741
@jrieken
properly layout tree
088b210
@jrieken
move sort order
5155502
@jrieken
add setting: outline.symbolSortOrder
a54c02a
@jrieken jrieken marked this pull request as ready for review December 24, 2020 09:59
@jrieken jrieken added notebook outline Source outline view issues labels Dec 24, 2020
@jrieken jrieken merged commit d883d37 into master Jan 4, 2021
@jrieken jrieken deleted the joh/toc branch January 4, 2021 11:46
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rheh rheh rheh left review comments

Assignees

@jrieken jrieken

Labels
notebook outline Source outline view issues
Projects
None yet
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.
2 participants
@jrieken @rheh