Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor context menu actions changed order #9737

Closed
isidorn opened this issue Jul 26, 2016 · 1 comment
Closed

Editor context menu actions changed order #9737

isidorn opened this issue Jul 26, 2016 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 26, 2016

Refs #9694

  1. Editor context menu on a method name
  2. Notice that the actions changed order when compared to the stable vscode
  3. This is playing with the users muscle memory and if possible we should keep the old order
  4. Note this change of order is present in most file types, not only ts

screen shot 2016-07-26 at 09 37 28
screen shot 2016-07-26 at 09 37 34

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jul 26, 2016
@jrieken jrieken added this to the July 2016 milestone Jul 26, 2016
@jrieken
Copy link
Member

jrieken commented Jul 26, 2016

Made some changes but didn't restore the old context menu 1 by 1 because (1) 'Change All' and 'Rename' should have been together before (they are related) and (2) I have moved 'primary' actions before their 'modified' version, e.g 'Go to Def' before 'Peek Def' and 'Rename' before 'Change All'. IMO that aligns nicely with the default keybindings where we have strong keybinding vs modifier+keybinding.

screen shot 2016-07-26 at 14 51 41

@jrieken jrieken closed this as completed Jul 26, 2016
@isidorn isidorn added the verified Verification succeeded label Jul 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants