Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language selector action and Cell toolbar are overlapping #96554

Closed
sandy081 opened this issue Apr 29, 2020 · 7 comments
Closed

Language selector action and Cell toolbar are overlapping #96554

sandy081 opened this issue Apr 29, 2020 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

#96279

I have notebook with following setup:

image

  • When I try to hover on language selector for first cell, the toolbar of second cell is getting overlapped.

image

@rebornix
Copy link
Member

@roblourens any idea about this one, is it possible that the status bar size is not included in the layout?

Also I'm seeing "GitHub-issues" language picker in a markdown cell
image

@roblourens
Copy link
Member

roblourens commented Apr 29, 2020

Probably somehow related to #96642.

I pushed a fix last night to include the height of the status bar. Should be in today's build.

@rebornix we have #96642

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook labels Apr 29, 2020
@roblourens roblourens added this to the April 2020 milestone Apr 29, 2020
@rebornix
Copy link
Member

@sandy081 do you have stable reproduce steps for this issue?

@rebornix rebornix added the info-needed Issue requires more information from poster label Apr 30, 2020
@roblourens
Copy link
Member

I think I saw this once after some dragging/dropping and folding/unfolding and editing but can't repro consistently.

What does it imply if the prefix sum computer returns a remainder?

image

image

@sandy081
Copy link
Member Author

Yeah I can't repro it but you can see that I got into this state.

It seems like this can happen when the two markdown cells are in edit mode which I am unable to get now.

@roblourens roblourens modified the milestones: April 2020, May 2020 May 2, 2020
@rebornix
Copy link
Member

rebornix commented May 7, 2020

I think this is probably because of a wrong layout (height calculation) of markdown cells, which has some new fixes in master today. Closing it for now and reopen if we see similar issues again.

@rebornix rebornix closed this as completed May 7, 2020
@rebornix rebornix removed the info-needed Issue requires more information from poster label May 7, 2020
@roblourens
Copy link
Member

Yeah I haven't seen it again.

@sandy081 sandy081 added the verified Verification succeeded label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants