Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook: first cell has a "Ctrl+Enter to run" but not play button #96438

Closed
bpasero opened this issue Apr 28, 2020 · 5 comments
Closed

Notebook: first cell has a "Ctrl+Enter to run" but not play button #96438

bpasero opened this issue Apr 28, 2020 · 5 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded web Issues related to running VSCode in the web
Milestone
April 2020

Comments

@bpasero
Copy link
Member

bpasero commented Apr 28, 2020

Refs: #96279

Unclear to me why the first cell has no run button, but same indication for using Ctrl+Enter to run?

image
@bpasero bpasero added web Issues related to running VSCode in the web notebook labels Apr 28, 2020
@jrieken
Copy link
Member

jrieken commented Apr 28, 2020

In the first cell, there is nothing to run. Only a variable is defined. The "Ctrl+Enter" message is gone in latest insiders which seems not to be deployed. fyi @roblourens

@jrieken jrieken closed this as completed Apr 28, 2020
@bpasero
Copy link
Member Author

bpasero commented Apr 28, 2020 •
edited
Loading

Yeah I am on yesterdays version it seems. Marking as bug to verify.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Apr 28, 2020
@bpasero bpasero added this to the April 2020 milestone Apr 28, 2020
@bpasero
Copy link
Member Author

bpasero commented Apr 29, 2020

Now I see a "Play" button but not the "Ctrl+Enter" thing?

image

@jrieken
Copy link
Member

jrieken commented Apr 29, 2020

Yeah, ctrl+enter is gone. The play button is maybe there because the cell is empty 🤔

jrieken added a commit to microsoft/vscode-github-issue-notebooks that referenced this issue Apr 30, 2020
@jrieken
Make the default runnable state be off, microsoft/vscode#96438
b441bcb
@jrieken
Copy link
Member

jrieken commented Apr 30, 2020

fyi - I have pushed a change that makes sure empty/new cells aren't runnable

@bpasero bpasero added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
2 participants
@bpasero @jrieken