Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more prominent focus indicator in trees #95768

Closed
Tyriar opened this issue Apr 21, 2020 · 5 comments
Closed

Use more prominent focus indicator in trees #95768

Tyriar opened this issue Apr 21, 2020 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality list-widget List widget issues tree-widget Tree widget issues ux User experience issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 21, 2020

From #93916

The different shades of backgrounds in the explorer are a little confusing:

image

A border could be nicer and more obvious which is the special item, it also aligned with Windows Explorer:

image
image

Related: #95767

@joaomoreno
Copy link
Member

What does Finder do?

@joaomoreno joaomoreno added the under-discussion Issue is under discussion for relevance, priority, approach label Apr 21, 2020
@joaomoreno
Copy link
Member

joaomoreno commented Apr 21, 2020

Also, this will affect users of the list/tree which use it in strange ways, outline for example. This is a big one.

Also, won't even start without a consensus from @microsoft/vscode

@Tyriar
Copy link
Member Author

Tyriar commented Apr 21, 2020

Finder doesn't distinguish the items:

Screen Shot 2020-04-21 at 7 22 55 AM

When right clicking everything gets a white outline:

Screen Shot 2020-04-21 at 7 23 24 AM

Right clicking something not in the selection will get a blue outline:

Screen Shot 2020-04-21 at 7 23 47 AM

@bpasero bpasero added list-widget List widget issues tree-widget Tree widget issues labels Apr 21, 2020
@joaomoreno joaomoreno added feature-request Request for new features or functionality ux User experience issues and removed under-discussion Issue is under discussion for relevance, priority, approach labels Apr 23, 2020
@joaomoreno joaomoreno added this to the Backlog milestone Apr 23, 2020
@akbyrd
Copy link
Contributor

akbyrd commented Jun 5, 2020

Windows resets selection on right click

Stupid Highlight 2

Windows also changes selection when you use the arrows keys

Stupid Highlight 3

In contrast with vscode which leaves a confusing persistent selection behind

Stupid Highlight

Stupid Highlight 4

@joaomoreno joaomoreno removed their assignment Nov 11, 2020
@joaomoreno joaomoreno changed the title Use more prominent focus indicator in explorer Use more prominent focus indicator in trees Feb 5, 2021
@joaomoreno joaomoreno self-assigned this Feb 5, 2021
@joaomoreno
Copy link
Member

This is now fixed

@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality list-widget List widget issues tree-widget Tree widget issues ux User experience issues
Projects
None yet
Development

No branches or pull requests

5 participants