Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List: range selection should update focused element #95767

Closed
Tyriar opened this issue Apr 21, 2020 · 2 comments
Closed

List: range selection should update focused element #95767

Tyriar opened this issue Apr 21, 2020 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality list-widget List widget issues *out-of-scope Posted issue is not in scope of VS Code ux User experience issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 21, 2020

Current behavior looks a little weird imo:

55a14309-f15c-49e4-97ff-7692a09c041b

I think the reason behind this is because the original item is important as it is the root item if the user shift+clicks elsewhere. But even so, the last clicked item is probably more important at this point. I suggest we move to what Windows explorer does and highlight the item that was most recently clicked:

222f4401-258b-4ba7-9d7a-834837ea9c24

@joaomoreno
Copy link
Member

joaomoreno commented Apr 21, 2020

This is hard to implement without introducing yet another trait in the list...

Also, aligning with Windows should not be our goal, but just provide a consistent experience. What does Finder do?

@joaomoreno joaomoreno added feature-request Request for new features or functionality under-discussion Issue is under discussion for relevance, priority, approach and removed feature-request Request for new features or functionality labels Apr 21, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Apr 21, 2020

Yes aligning with Windows Explorer isn't the goal, making it functionality and as users expect is. Windows Explorer happens to have maintained a tree view for decades so it's a good point of reference.

Finder's behavior: #95768 (comment)

@joaomoreno joaomoreno changed the title Change shift+click multi-select "primary item" to what was last clicked List: range selection should update focused element Apr 23, 2020
@joaomoreno joaomoreno added list-widget List widget issues feature-request Request for new features or functionality ux User experience issues and removed under-discussion Issue is under discussion for relevance, priority, approach labels Apr 23, 2020
@joaomoreno joaomoreno added this to the Backlog milestone Apr 23, 2020
@joaomoreno joaomoreno added the *out-of-scope Posted issue is not in scope of VS Code label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality list-widget List widget issues *out-of-scope Posted issue is not in scope of VS Code ux User experience issues
Projects
None yet
Development

No branches or pull requests

2 participants