Global search is slow and inaccurate

[tszalbot]

Issue Type: Bug

Global searchin through files with CTRL+SHIFT+F doesn't give any results, when searching for files with CTRL+P some files are missing

VS Code version: Code 1.44.0 (2aae1f2, 2020-04-07T23:31:18.860Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 x 2208)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.85GB (7.87GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (9)

Extension	Author (truncated)	Version
htmltagwrap	bra	0.0.7
vscode-eslint	dba	2.1.2
gitlens	eam	10.2.1
vscode-isml-linter	fab	1.0.0
python	ms-	2020.3.71659
powershell	ms-	2020.3.0
LiveServer	rit	5.6.1
prophet	Sqr	1.3.1
alphabetical-sorter	ue	2.0.1

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Global search (#74251)

[DCrow]

Having the same issue, when using CMD+P not all result are displayed and a progress bar is displayed under search bar, but even after waiting for several minutes nothing changes.

VS Code

Version: 1.44.0
Commit: 2aae1f26c72891c399f860409176fe435a154b13
Date: 2020-04-08T08:23:56.137Z (2 days ago)
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.7.0

[tszalbot]

@DCrow Exactly this...
Seems like the previous search results are cached and outdated, but the new ones aren't coming up

[DCrow]

@tszalbot I think it is related to Quick Open rewrite which landed in this version

[DCrow]

These issues seem to be related #94802, #94871, #94880, #94885

[JacksonKearl]

@roblourens Seeing lots of issues about this in the new release. I'm not aware of any changes in the area, do you have any ideas? I recall in the past we had a similar issue caused by the view rewrite, which may be related.

[roblourens]

No real changes here, and the Quick Open changes didn't affect text search. Please see whether any tips in here help: https://github.com/microsoft/vscode/wiki/Search-Issues

[roblourens]

Also, do you have a folder in your workspace that adds a custom file system?

Does it work if you open a single folder?

[DCrow]

@roblourens
In my .code-workspace file I had something like

        {
            "name": "Repo @ 154ae10",
            "uri": "gitlens://154ae10/Users/ybarkovskij/Work/Repo?{\"path\":\"/Users/ybarkovskij/Work/Cat-DB\",\"ref\":\"154ae10f72b8eaesd9949650f0c4c42be04fe65f\",\"repoPath\":\"/Users/ybarkovskij/Work/Repo\"}"
        }

And in developer console there was a warning No search provider registered for scheme: gitlens, waiting
After removing this folder directly from .code-workspace file, everything started working normally.

Also if I downgraded to 1.43.2 everything was also working correctly.

[tszalbot]

@DCrow

After removing this folder directly from .code-workspace file, everything started working normally.

Did the same on an external folder and it started working. Thanks a lot!
I wasn't using this folder anyway, so no big deal in this case.
Apparently it will be fixed in #95010

[roblourens]

Yeah, it's a duplicate. Sorry, fix on the way, and it's fixed in Insiders