New Quick Open widget cannot search for full path to file

[thernstig]

• VSCode Version: 1.44.0
• OS Version: Windows 10 Pro 1809 (and VS Code Remote host: Ubuntu 16.04.5)

Steps to Reproduce:

1. Press ctrl+e or ctrl+p to search for a file. Enter a full path like server/path/to/file.js
2. No results are shown.

This is a common scenario where you might get a link to a file from e.g. output logs in CI machinery, and you want to open that file quickly, you copy&paste the path from the console into ctrl+p. This worked perfectly fine before 1.44.0 so I assume the new "Quick Open rewrite" is in works here: https://code.visualstudio.com/updates/v1_44#_quick-open-rewrite

Does this issue occur when all extensions are disabled?: Yes

[poebrand]

Same issue here.
Does this issue occur when all extensions are disabled?: Yes

Downgraded to 1.43.2 and crtl+p started working.

[bpasero]

@thernstig @poebrand I would appreciate a complete instruction for me how to reproduce, preferably with a sample repo to clone, or even using vscode repo itself.

It seems to me you are trying on Windows and you are using slash instead of backslash. Though I do not see an issue:

[thernstig]

I cannot provide a repro of my repo, since it is private.

But you are correct in your assertion. I am using forward slash because I am using remote SSH to an Ubuntu host, where they are forward slash.

Does that give enough details, or if you do the same (connect via SSH to a remote repo, whilst using VS Code in Windows) still work for you? Otherwise I'll see if I can create a minimal repro of this.

[bpasero]

@thernstig a minimal repro would still be great and especially of interest if this reproduces only against a remote (such as SSH) or locally as well. Thanks

[poebrand]

My repo is also a private. It is about 8,000 files. However, in my case I wasn't entering a path. I was just typing in the name of a JavaScript file: NotifyMe.js

The animation under the search bar just kept going. Indefinitely. I tried closing VS Code and restarting the computer... issue did not go away.

[bpasero]

I really need a repro, sorry. Otherwise I cannot be of any help.

[thernstig]

@bpasero This is a minimum repro that does not work, see image.

Windows 10 Pro 1809 (17763.1131)
Remote: Ubuntu 16.04.5 LTS

[bpasero]

This looks like a remote issue to me, given the SSH decoration.

[bpasero]

A regression, but not sure this being a candidate or not. Will push a fix for April and people can switch over to insiders to benefit.

Previously we would allow a file to appear in quick open, even if our fuzzy scorer produced no match. This became more strict with the rewrite. Suggested fix is to treat "/" and "\" equal in the scoring logic.

[ThiefMaster]

Works fine in the latest insiders, thanks for the quick fix!