Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't render 2 notebooks? #91506

Closed
sbatten opened this issue Feb 26, 2020 · 3 comments
Closed

Can't render 2 notebooks? #91506

sbatten opened this issue Feb 26, 2020 · 3 comments
Assignees
@rebornix @mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded webview Webview issues
Milestone
March 2020

Comments

@sbatten
Copy link
Member

sbatten commented Feb 26, 2020 •
edited
Loading

refs #91328

Open 2 notebooks side by side:

e.g. runCode_iframe_form_15.ipynb and runCode-slim.ipynb

iframes fail to render
@sbatten sbatten assigned sbatten and rebornix and unassigned sbatten Feb 26, 2020
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook labels Feb 27, 2020
@rebornix rebornix added this to the March 2020 milestone Feb 27, 2020
@rebornix rebornix added the webview Webview issues label Mar 3, 2020
mjbvz added a commit that referenced this issue Mar 3, 2020
@mjbvz
Add explicit wait on protocol registration
ed8c0e4 
Possible fix for #89038/#91506. In both cases, it looks like we try to use the protocol before it is properly registered. If this fix doesn't work, there's probably something weird going on on the electron side of things
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 3, 2020

@rebornix Can you please test the change I just pushed. The error does not happen reliably so I'm not sure if I fixed it or not

@rebornix rebornix mentioned this issue Mar 4, 2020
Closed
@rebornix
Copy link
Member

rebornix commented Mar 4, 2020

It seems it's fixed. I'll close it for now, thanks for the quick fix!

@rebornix rebornix closed this as completed Mar 4, 2020
@rebornix
Copy link
Member

rebornix commented Mar 4, 2020

Verification:

  • Open a notebook which contains html outputs
  • Split the editor
  • Make sure the html outputs are rendered in both panels.

@roblourens roblourens added the verified Verification succeeded label Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded webview Webview issues
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
4 participants
@roblourens @rebornix @sbatten @mjbvz