Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact folders: Context menu actions not focus aware when selection is set #86408

Closed
aeschli opened this issue Dec 5, 2019 · 1 comment
Closed

Compact folders: Context menu actions not focus aware when selection is set #86408

aeschli opened this issue Dec 5, 2019 · 1 comment
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone
November 2019

Comments

@aeschli
Copy link
Contributor

aeschli commented Dec 5, 2019 •
edited
Loading

  • open a remote WSL window
  • clone https://github.com/eclipse/eclipse.jdt.ui.git
  • set "explorer.compactFolders": true
  • in the explorer, set the selection on org.eclipse.jdt.junit.runtime - src -org\eclipse\jdt\internal\junit\runner
  • Move the mouse over jdt, open the context menu and `Copy Relative Path'
    Paste:
    org.eclipse.jdt.junit.runtime\src
    org.eclipse.jdt.junit.runtime\src\org
    org.eclipse.jdt.junit.runtime\src\org\eclipse
    org.eclipse.jdt.junit.runtime\src\org\eclipse\jdt
    org.eclipse.jdt.junit.runtime\src\org\eclipse\jdt\internal
    org.eclipse.jdt.junit.runtime\src\org\eclipse\jdt\internal\junit
    org.eclipse.jdt.junit.runtime\src\org\eclipse\jdt\internal\junit\runner

-> expected org.eclipse.jdt.junit.runtime\src\org\eclipse\jdt

  • Open terminal: Opens on org.eclipse.jdt.junit.runtime\src\org\eclipse\jdt\internal\junit\runner, expected org.eclipse.jdt.junit.runtime\src\org\eclipse\jdt
  • Find in FIles: Contains full list, expected: just jdt
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Dec 5, 2019
@aeschli aeschli mentioned this issue Dec 5, 2019
Closed
@aeschli aeschli removed the terminal General terminal issues that don't fall under another label label Dec 5, 2019
@aeschli aeschli changed the title Compact folders: Open terminal not selection aware Compact folders: Context menu actions not focus aware when selection is set Dec 5, 2019
@aeschli aeschli added the file-explorer Explorer widget issues label Dec 5, 2019
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Dec 5, 2019
@isidorn isidorn closed this as completed in ac3fab2 Dec 5, 2019
@isidorn isidorn added this to the November 2019 milestone Dec 5, 2019
@isidorn
Copy link
Contributor

isidorn commented Dec 5, 2019

Thanks for filling this. Getting this contexts properly is more tricky than I anticipated.

@aeschli aeschli mentioned this issue Dec 5, 2019
Closed
@eamodio eamodio added the verified Verification succeeded label Dec 5, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
3 participants
@eamodio @isidorn @aeschli