Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact folders: Context menu actions not selection aware #86103

Closed
aeschli opened this issue Dec 3, 2019 · 4 comments
Closed

Compact folders: Context menu actions not selection aware #86103

aeschli opened this issue Dec 3, 2019 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Dec 3, 2019

Testing #85928

The path copied is org.eclipse.jdt.junit.runtime/src/org/eclipse/jdt/internal/junit/runner

Same with other context menu command: Open in Terminal, Find in Folder..., New File...
Rename & Copy seem to work.

@isidorn isidorn assigned isidorn and unassigned joaomoreno Dec 4, 2019
@isidorn isidorn added this to the November 2019 milestone Dec 4, 2019
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Dec 4, 2019
@isidorn
Copy link
Contributor

isidorn commented Dec 4, 2019

Good catch. Debt follow up work #86268

Verifier have the compact folders in the explorer and verify all context menu actions work on the expected context (if you click on the middle item it will execute on it).

@isidorn isidorn closed this as completed in 0dbe568 Dec 4, 2019
@aeschli
Copy link
Contributor Author

aeschli commented Dec 5, 2019

Open Terminal still opens on the wrong folder. Created #86408

@aeschli
Copy link
Contributor Author

aeschli commented Dec 5, 2019

Oh, it's much more. It depends on where the selection is (not just the focus).

  • open a remote WSL window
  • clone https://github.com/eclipse/eclipse.jdt.ui.git
  • set "explorer.compactFolders": true
  • in the explorer, set the selection on org.eclipse.jdt.junit.runtime - src -org\eclipse\jdt\internal\junit\runner
  • Move the mouse over jdt, open the context menu and `Copy Relative Path'
    Paste:
    org.eclipse.jdt.junit.runtime\src
    org.eclipse.jdt.junit.runtime\src\org
    org.eclipse.jdt.junit.runtime\src\org\eclipse
    org.eclipse.jdt.junit.runtime\src\org\eclipse\jdt
    org.eclipse.jdt.junit.runtime\src\org\eclipse\jdt\internal
    org.eclipse.jdt.junit.runtime\src\org\eclipse\jdt\internal\junit
    org.eclipse.jdt.junit.runtime\src\org\eclipse\jdt\internal\junit\runner

I changed #86408 to that.

@aeschli
Copy link
Contributor Author

aeschli commented Dec 5, 2019

If the selection is somewhere else, things work. Marking as verified.

@aeschli aeschli added the verified Verification succeeded label Dec 5, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants