Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt extension kind for those extensions defined as ui extensions #85819

Closed
12 tasks done
sandy081 opened this issue Nov 29, 2019 · 5 comments
Closed
12 tasks done

Adopt extension kind for those extensions defined as ui extensions #85819

sandy081 opened this issue Nov 29, 2019 · 5 comments
Assignees
Labels
plan-item VS Code - planned item for upcoming
Milestone

Comments

@sandy081
Copy link
Member

sandy081 commented Nov 29, 2019

Adoption for #85036

Background

  • As of 1.40 the extensionKind attribute can be an array, pls see the documentation.
  • We will be deprecating the string type for extensionKind property in favour of string array type to cause less confusions and the new extensionKind must be adopted.

Adoption

If you have an extension with the extensionKind set to "ui", then you must change the extension kind to:

  • ["ui"] - when the extension only runs locally in the local extension host and does not run in a remote context. For example, extensions contributing a resolvercan only run locally.
  • ["ui", "workspace] - when the extension can run both locally and remotely, but locally is preferred. For example, personalisation extensions like key bindings can run both locally and remotely, but if the extension is already installed locally it will be used.

Details about the New Format & Behaviour

Kind \ Runtime Desktop - Local Desktop - Remote Web - Remote
["ui"] ✔️
["workspace"] ✔️ ✔️
["ui", "workspace"] ✔️ ✔️ ✔️
["workspace", "ui"] ✔️ ✔️ ✔️

["ui"]: Runs only locally.
["workspace"]: Runs only remotely.
["ui", "workspace"]: Preferably runs locally if exists otherwise can run remotely.
["workspace", "ui"]: Preferably runs remotely if exists otherwise can run locally.

Adoption Tracking

Please go through the extensions listed below and adopt your extension to use the new array format correctly as per above table.

  • Git UI Extension git-ui - @chrmarti
  • Image Preview Extension image-preview - @mjbvz
  • Remote Containers Extension ms-vscode-remote.remote-containers ["ui"]- @chrmarti
  • Remote SSH Edit Extension ms-vscode-remote.remote-ssh-edit ["ui"]- @roblourens
  • Remote SSH Extension ms-vscode-remote.remote-ssh ["ui"]- @roblourens
  • Remote WSL Extension ms-vscode-remote.remote-wsl ["ui"]- @aeschli
  • Remote Development Extension Pack ms-vscode-remote.vscode-remote-extensionpack ["ui"] - @roblourens @aeschli @chrmarti
  • Notepad++ Keymap Extension ms-vscode.notepadplusplus-keybindings ["ui", "workspace"] - @chrisdias
  • Sublime Keymap Extension ms-vscode.sublime-keybindings ["ui", "workspace"] - @chrisdias
  • Debugger for Chrome Extension msjsdiag.debugger-for-chrome ["ui"] - @roblourens
  • Debugger for Edge Extension msjsdiag.debugger-for-edge ["ui"] - @roblourens
  • Test Resolver vscode-test-resolver ["ui"] - @aeschli

@alexandrudima FYI

@RMacfarlane
Copy link
Contributor

@chrmarti Correct me if I'm wrong, but the Azure Account Extension is currently a workspace extension and various other workspace extensions depend on it (Docker, Azure functions). Since it doesn't set extensionKind to ui, I'm going to remove it from the list

@sandy081
Copy link
Member Author

sandy081 commented Dec 6, 2019

Ping @chrisdias and @mjbvz for pending adoptions

@sandy081 sandy081 assigned mjbvz and unassigned egamma, RMacfarlane and chrmarti Dec 6, 2019
@mjbvz mjbvz removed their assignment Dec 6, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 6, 2019

I already adopted this in the image-preview with b0fb9f1

@chrisdias
Copy link
Member

done

@sandy081
Copy link
Member Author

sandy081 commented Dec 9, 2019

Great. Thanks guys.

@sandy081 sandy081 closed this as completed Dec 9, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plan-item VS Code - planned item for upcoming
Projects
None yet
Development

No branches or pull requests

8 participants