-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline all SVGs for the workbench when building #8516
Comments
@bgashler1 we have many places in code where the same SVG is referenced in a rule with Do you recall why for HC theme we do this? If we inline all SVGs, we end up duplicating the data URI value if we reference the image multiple times. Maybe there is a way to avoid this and still have a good looking HC theme? |
Interesting, on Mac comparing the 2 application bundles I see this:
So, in raw bytes we loose, but in terms of allocated disk space we win :) |
Removing junk metadata and unused classes I think can be done automatically with this or another gulp package https://www.npmjs.com/package/gulp-svgmin The reason why we historically started doing pseudo elements with |
@bgashler1 I commented on that issue, imho we should make this change and delete all our custom HC rules. This would not only enable this issue for inlining but also make it much easier to introduce new icons to Code because you don't have to deal with this ugly hack. |
Pushed to master. I got rid of our high contrast CSS hacks for background image. |
Note: one issue we have is that many SVG icons contain metadata or unused CSS classes.
To fix #7839
The text was updated successfully, but these errors were encountered: