Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Integrated terminal IME support #9695

Closed
3 tasks done
Tyriar opened this issue Jul 25, 2016 · 7 comments
Closed
3 tasks done

Test: Integrated terminal IME support #9695

Tyriar opened this issue Jul 25, 2016 · 7 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 25, 2016

Test for #7045:

The integrated terminal now supports input via IMEs (Input Method Editors). During development I tested this across all 3 OS' with Japanese and Korean IMEs as I'm familiar with them. Here are some things to try:

  • Install/enable an IME for the OS, preferably not Japanese/Korean
  • Test input, if you're familiar with the IME try all the edge cases
    • Multiple character compositions?
    • Multiple keystrokes per character?
    • Multiple characters reducing to a single character?
  • Test executing a command using the text (eg. echo)

See xtermjs/xterm.js#175 for more details on the change and testing that was performed at implementation time.

@Tyriar Tyriar added this to the July 2016 milestone Jul 25, 2016
@Tyriar Tyriar self-assigned this Jul 25, 2016
@egamma egamma mentioned this issue Jul 25, 2016
89 tasks
@Tyriar Tyriar removed their assignment Jul 25, 2016
@ZCShou
Copy link

ZCShou commented Jul 26, 2016

@Tyriar Cannot follow cursor! The first input is ok ,but The following Input can not work well!

Win10 x64 Chinese IME

@rebornix
Copy link
Member

@Tyriar try type two Chinese characters then switch to English and type 'abc', you will see the cursor position is wrong, which breaks deleting functionality.

@Tyriar
Copy link
Member Author

Tyriar commented Jul 26, 2016

@ZCShou @rebornix are you experiencing the cursor-related issue I describe at the bottom of xtermjs/xterm.js#175 (comment)? I found that input seemed fine but the cursor disappeared so the composition window was never in the right position.

@rebornix
Copy link
Member

@Tyriar I ran into the issue you described there and the input works fine. Besides, the cursor position comes back if you switch to English IME but the position is wrong, and its offset depends on how many Chinese characters you type

At first, type abc and the cursor is at the right of last char.

image

Then type a Chinese char (lv) and abc again

image

See above, the cursor is on last char. Then you type (peng) and abc

image

The cursor now is on the last two char of text. I suppose its offset is just how many Chinese chars you type. My suspicion is we don't move the cursor position when we handle CJK IME composition?

@Tyriar
Copy link
Member Author

Tyriar commented Jul 26, 2016

The cursor position is handled entirely by the pty though, not vscode. I wonder if this is something to do with #7345 which is an upstream problem that does weird things when using backspace/left/right.

@joaomoreno
Copy link
Member

@Tyriar I've found it hard to test and even to know whether what I did actually tested your work. I followed a guide or two in installing IMEs, I was able to type some Japanese/Korean, but I'm not sure I actually tested what you should be tested.

@Tyriar
Copy link
Member Author

Tyriar commented Jul 26, 2016

@joaomoreno no problems, I did a bunch of testing myself on Linux so hopefully that will be enough.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants