Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for custom editors in the workbench #84672

Closed
6 tasks done
bpasero opened this issue Nov 13, 2019 · 4 comments
Closed
6 tasks done

Support for custom editors in the workbench #84672

bpasero opened this issue Nov 13, 2019 · 4 comments
Assignees
@bpasero
Labels
custom-editors Custom editor API (webview based editors) plan-item VS Code - planned item for upcoming
Milestone
February 2020

Comments

@bpasero
Copy link
Member

bpasero commented Nov 13, 2019 •
edited
Loading

To support custom editors (#77131, #12176) we need our IWorkingCopyService to become more powerful, specifically taking over responsibility of:

Work Areas:

  • dirty tracking
  • save/revert
  • auto save
  • hot exit
  • structural changes (move, delete, create, copy)
  • save participants (text file based only, we do not plan for an API for other extensions to modify the custom editor data)
@bpasero bpasero added the debt Code quality issues label Nov 13, 2019
@bpasero bpasero added this to the November 2019 milestone Nov 13, 2019
@bpasero bpasero self-assigned this Nov 13, 2019
bpasero added a commit that referenced this issue Nov 13, 2019
@bpasero
open editors - adopt working copy service and track unsaved properly (#…
557d444 
…84672)
bpasero added a commit that referenced this issue Nov 13, 2019
@bpasero
working copy - reduce dirty listeners and support "save all" action e…
f91e3ee 
…nablement (#84672)
bpasero added a commit that referenced this issue Nov 15, 2019
@bpasero
working copy - introduce first save/revert semantics (#84672)
72c2f50
bpasero added a commit that referenced this issue Nov 17, 2019
@bpasero
working copies - properly implement save, saveAs, saveAll (#84672)
00688bf
@bpasero bpasero changed the title Implement and adopt working copy service Support for custom editors in the workbench Nov 17, 2019
@bpasero
Copy link
Member Author

bpasero commented Nov 18, 2019 •
edited
Loading

I think we settled on saving everything, even working copies from custom editors.

@bpasero bpasero mentioned this issue Nov 19, 2019
Closed
3 tasks
@DonJayamanne
Copy link
Contributor

@bpasero @mjbvz Is the plan to (try) ship the custom editor in the next release?
I'd like to ensure we (Python Extension) uses this when its available.

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 20, 2019 •
edited
Loading

No. It will remain as proposed api in 1.41

bpasero added a commit that referenced this issue Nov 21, 2019
@bpasero
support auto save on focus lost for all editors (#84672)
a825aaa
@bpasero bpasero modified the milestones: November 2019, December 2019 Dec 5, 2019
@bpasero bpasero added plan-item VS Code - planned item for upcoming and removed debt Code quality issues labels Dec 5, 2019
bpasero added a commit that referenced this issue Jan 10, 2020
@bpasero
editors - save dirty working copy after delay (for #84672)
cf0fd9a
@bpasero
Copy link
Member Author

bpasero commented Jan 10, 2020 •
edited
Loading

All editor auto save functionality will now work for custom editors as well.

bpasero added a commit that referenced this issue Jan 12, 2020
@bpasero
custom editors - implement auto save and backup creation over working…
e6651b9 
… copy events (#84672)
bpasero added a commit that referenced this issue Jan 14, 2020
@bpasero
implement backup on shutdown via working copies (#84672)
1f5a547
@bpasero bpasero modified the milestones: January 2020, February 2020 Jan 24, 2020
This was referenced Jan 24, 2020
Closed
Closed
@bpasero bpasero added the custom-editors Custom editor API (webview based editors) label Feb 4, 2020
bpasero added a commit that referenced this issue Feb 18, 2020
@bpasero
working copy - expose file IO operations for participation (#84672)
b6e4587
@bpasero bpasero closed this as completed Feb 18, 2020
@egamma egamma mentioned this issue Feb 18, 2020
Closed
54 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
custom-editors Custom editor API (webview based editors) plan-item VS Code - planned item for upcoming
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
3 participants
@bpasero @DonJayamanne @mjbvz