Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show keybindings in refactor menu #84101

Closed
mjbvz opened this issue Nov 7, 2019 · 1 comment
Closed

Show keybindings in refactor menu #84101

mjbvz opened this issue Nov 7, 2019 · 1 comment
Assignees
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 7, 2019

Repo

  1. Create a keybinding for extract constant:
	{
		"key": "shift+ctrl+e",
		"command": "editor.action.refactor",
		"args": {
			"kind": "refactor.extract.constant",
			"preferred": true
		}
	}
  1. Open a js file:

    const a = 1 + 2;
  2. Select 1 + 2 and click on lightbulb

Feature Request

Show the keybinding (shift+ctrl+e) for the extract to constant refactoring the lightbulb menu

@mjbvz mjbvz added the feature-request Request for new features or functionality label Nov 7, 2019
@mjbvz mjbvz self-assigned this Nov 7, 2019
@mjbvz mjbvz added this to the November 2019 milestone Nov 7, 2019
@mjbvz mjbvz closed this as completed in 010abd3 Nov 7, 2019
@mjbvz
Copy link
Collaborator Author

mjbvz commented Nov 7, 2019

For verifying this:

  1. Make sure that the most specific keybinding is shown if multiple could be used
  2. Also check that source actions (like organize imports) have keybindings shown in the source menu

@mjbvz mjbvz added editor-code-actions Editor inplace actions (Ctrl + .) verification-needed Verification of issue is requested labels Nov 7, 2019
@connor4312 connor4312 added the verified Verification succeeded label Dec 3, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants