Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'machine-overridable' can be set and read in user settings #79983

Closed
aeschli opened this issue Aug 28, 2019 · 3 comments · Fixed by microsoft/azuredatastudio#7206
Closed

'machine-overridable' can be set and read in user settings #79983

aeschli opened this issue Aug 28, 2019 · 3 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues verified Verification succeeded
Milestone
August 2019

Comments

@aeschli
Copy link
Contributor

aeschli commented Aug 28, 2019 •
edited
Loading

Verifying #73985

  • Create a machine-overridable settings

e.g. 'testFoo.test-machine-overridable' from ext-machinescope-test-0.0.4.vsix.zip

  • in a normal (non-remote window) set it in user and workspace settings
    -> no errors (as expected)
  • open the folder in a remote window
    -> no errors (expect error in user settings)

The UI only offers the setting in machine and workspace, but the editor schema seems to be lacking the schema.

  • clear workspace setting and runTest Foo Setting command. You can see that the value is read from the user settings.
@aeschli
Copy link
Contributor Author

aeschli commented Aug 28, 2019 •
edited
Loading

ext-machinescope-test-0.0.4.vsix.zip

@aeschli aeschli changed the title No warning when using 'machine-overridable' setting in user settings 'machine-overridable' can be set in user settings Aug 28, 2019
@aeschli aeschli changed the title 'machine-overridable' can be set in user settings 'machine-overridable' can be set and read in user settings Aug 28, 2019
@aeschli aeschli mentioned this issue Aug 28, 2019
Closed
@sandy081
Copy link
Member

Good catch @aeschli. There is a bug that if the setting is already overridden in user settings, it is being read because defaults are getting registered lately. It needs reprocessing after defaults are registered.

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues labels Aug 28, 2019
@sandy081 sandy081 added this to the August 2019 milestone Aug 28, 2019
@sandy081
Copy link
Member

Also fixed the schemas to show the suggestions correctly.

sandy081 added a commit that referenced this issue Aug 28, 2019
@sandy081
#79983 add tests
5b991cf
hunghw pushed a commit to hunghw/vscode that referenced this issue Aug 28, 2019
@sandy081 @hwhung0111
Fix microsoft#79983
35c28ed
hunghw pushed a commit to hunghw/vscode that referenced this issue Aug 28, 2019
@sandy081 @hwhung0111
microsoft#79983 add tests
9cb3a64
@alexr00 alexr00 added the verified Verification succeeded label Aug 29, 2019
@anthonydresser anthonydresser mentioned this issue Sep 13, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues verified Verification succeeded
Projects
None yet
Milestone
August 2019
Development

Successfully merging a pull request may close this issue.

Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 microsoft/azuredatastudio
3 participants
@aeschli @sandy081 @alexr00