Insert final newline moves cursor

[sumneko]

Steps to Reproduce:

1. Set Files: Insert Final Newline to true.
2. Input some words in a ts file.
3. View the competion items in competion hover.
4. VSCode inserts the final newline and close the competion hover.
5. Frustrated.

[jrieken]

VSCode inserts the final newline and close the competion hover.

Sorry, I don't understand what's happening here. Do you accept a completion? How/why does the widget close? Are pressing any key? Can you reproduce without extensions? What version of VS Code is this?

[sumneko]

VSCode inserts the final newline and close the competion hover.

Sorry, I don't understand what's happening here. Do you accept a completion? How/why does the widget close? Are pressing any key? Can you reproduce without extensions? What version of VS Code is this?

1. I did not accept any completion.
2. The widget closed by VSCode due to inserting final newline.
3. Dose not press any key except down arrow (This key has nothing to do with the problem.).
4. This can be reproduced without any extensions.
5. VSCode version:

版本: 1.37.1 (user setup)
提交: f06011ac164ae4dc8e753a3fe7f9549844d15e35
日期: 2019-08-15T16:17:55.855Z
Electron: 4.2.7
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362

[jrieken]

This can be reproduced without any extensions.

Sorry, no. I cannot reproduce. Please follow these steps to really disable extensions. Select 'Extensions View > ... > Disable all Installed Extensions', reload, and try again. Thanks.

[sumneko]

This can be reproduced without any extensions.

Sorry, no. I cannot reproduce. Please follow these steps to really disable extensions. Select 'Extensions View > ... > Disable all Installed Extensions', reload, and try again. Thanks.

Only reproduced when editing the last line, I forgot to mention this key point. It's my mistake.

[sumneko]

[sumneko]

I did a further test, to reproduce this, the following conditions must be met simultaneously:

1. Set Files: Insert Final Newline to true.
2. Set Files: Auto Save to afterDelay.
3. Input on the last line.

[jrieken]

Thanks. I can reproduce now.

[jrieken]

Ok, full steps

• enable final newline insertions
• enable auto save
• type and trigger suggest on the very last line
• wait a little
• 🐛 suggest widget closes

The debugger state below shows what's happening. The insert final newline logic kicks in (while suggest is active) and ends up moving the cursor position (from line 42 to line 43). Because the cursor moves suggest cancels and hides the widget.

[bpasero]

@alexandrudima need your advice here, in the end I call:

model.pushEditOperations(prevSelection, [EditOperation.insert(new Position(lineCount, model.getLineMaxColumn(lineCount)), model.getEOL())], edits => prevSelection)

I think this is not just about inserting a final new line but any edit operation can potentially close suggest.

Btw for me the cursor does not move, but suggest still closes.

[jrieken]

Btw for me the cursor does not move, but suggest still closes.

Maybe that's an intermediate cursor state?

[alexdima]

@bpasero I think because the edits are done directly on the model, the cursor of the current editor can only adjust to the edit. It would be better if the edits would be done through the current editor. i.e. ICodeEditor.executeEdits

[bpasero]

I pushed both a fix in cursor.ts with Alex and adopted the ICodeEditor.executeEdits. I stayed away from using it for other places where we use the model edit.