Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Editors: middle mouse closes and opens editor #79786

Closed
bpasero opened this issue Aug 26, 2019 · 2 comments
Closed

Open Editors: middle mouse closes and opens editor #79786

bpasero opened this issue Aug 26, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Aug 26, 2019

Steps to Reproduce:

  1. open some editors in multiple groups
  2. middle-click into the non-active group editor in the open editors view

=> 🐛 the editor closes but also opens the next editor in the list

I would expect the editor to close and not open.

@isidorn pushed a workaround, please check: b032304

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Aug 26, 2019
bpasero added a commit that referenced this issue Aug 26, 2019
@isidorn
Copy link
Contributor

isidorn commented Aug 26, 2019

@bpasero thanks, I will check it in the afternoon (since currenly I do not have a mouse).

@isidorn isidorn added this to the August 2019 milestone Aug 26, 2019
@isidorn
Copy link
Contributor

isidorn commented Aug 26, 2019

I can not reproduce the issue with Insiders from 3 days ago which does not contain your fix
However your fix looks good, and looking at the code and analysing the behavior on my machine I am just lucky that onDidOpen fires first, and only latter the onMiddleClick fires. So for me first I open it which is a no-op, and then the middleClick comes which closes it resulting in a correct behavior at the end.
However your fix is good, since it covers this case when the events come in the opposite order.
Thus closing

lala

@isidorn isidorn closed this as completed Aug 26, 2019
@bpasero bpasero self-assigned this Aug 27, 2019
hunghw pushed a commit to hunghw/vscode that referenced this issue Aug 28, 2019
@mjbvz mjbvz added the verified Verification succeeded label Aug 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants